[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15305 - in trunk: subversion/bindings/swig subversion/bindings/swig/ruby/libsvn_swig_ruby

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-07-09 16:49:31 CEST

Hi,

In <42CFDC9C.8090302@electricjellyfish.net>
  "Re: svn commit: r15305 - in trunk: subversion/bindings/swig subversion/bindings/swig/ruby/libsvn_swig_ruby" on Sat, 09 Jul 2005 07:18:04 -0700,
  Garrett Rooney <rooneg@electricjellyfish.net> wrote:

> kou@tigris.org wrote:
>
> > +void
> > +svn_swig_rb_nls_initialize(void)
> > +{
> > +#ifdef ENABLE_NLS
> > +# ifdef WIN32
> > +# else
> > + bindtextdomain(PACKAGE_NAME, SVN_LOCALE_DIR);
> > +# ifdef HAVE_BIND_TEXTDOMAIN_CODESET
> > + bind_textdomain_codeset(PACKAGE_NAME, "UTF-8");
> > +# endif
> > +# endif
> > +#endif
> > +}
>
> Any reason not to include the win32 part of this? Just that you can't
> test it?

Yes.

> Also, the fact that this is essentially copy and pasted from
> svn_cmdline_init tells me that perhaps we need a helper function
> somewhere for this functionality...

I thought that I request breaking down svn_cmdline_init
after I test some environment.

Just a moment, please. I'll make a patch now.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 9 16:50:25 2005

This is an archived mail posted to the Subversion Dev mailing list.