[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Unexpected behavior from psvn.el

From: Kalle Olavi Niemitalo <kon_at_iki.fi>
Date: 2005-07-09 01:07:11 CEST

Michael W Thelen <mike@pietdepsi.com> writes:

> Michael W Thelen wrote:
>> Thank you for the patch... since psvn.el is in the contrib area, and I
>> believe Stefan Reichör (xsteve) is mainly responsible for maintaining
>> it, we may want his input on whether this change should be made. Stefan
>> and any other interested developers, what do you think?
> http://subversion.tigris.org/issues/show_bug.cgi?id=2357

I think it would be a good change wrt svn commit. However:

* svn-status-add-file already uses --non-recursive, so I think
  svn-log-edit-done should also use that, rather than -N.

* I'd rather not have commit treat the list of marked files
  differently from other commands, unless there is a specific
  reason. The current list (as of r15300 in trunk) seems to be:

  - svn add (svn-status-add-file-recursively,
    svn-status-add-file): both options available
  - svn blame (svn-status-blame): no such options
  - svn cat (svn-status-get-specific-revision-internal): no such
  - svn cleanup (svn-status-cleanup): no such options
  - svn commit (svn-log-edit-done): recursive by default, but the
    patch would change this
  - svn diff (svn-status-show-svn-diff-internal): recursive by
    default; (svn-log-view-diff): recursive by default but
    ignores marks
  - svn info (svn-status-parse-info, svn-status-info): not
    recursive by default
  - svn log (svn-status-show-svn-log): no such options
  - svn mkdir (svn-status-make-directory): no such options
  - svn mv (svn-status-mv): no such options
  - svn propdel (svn-status-property-parse-property-names): not
    recursive by default
  - svn propget (svn-status-property-edit,
    svn-log-edit-log-entry): not recursive by default
  - svn proplist (svn-status-property-list,
    svn-status-proplist-start): no such options
  - svn propset (svn-status-property-parse-property-names,
    svn-prop-edit-do-it, svn-log-edit-done): not recursive by
  - svn resolved (svn-status-resolved): not recursive by default
  - svn revert (svn-status-revert): not recursive by default
  - svn rm (svn-status-rm): no such options
  - svn status (svn-status): recursive, but ignores marks
  - svn update (svn-status-update-cmd): recursive by default,
    but ignores marks

  So, the question is whether svn diff of marked files should be
  --non-recursive. I think it should, because I remember having
  gotten duplicate diffs due to marking both a directory and the
  files in it.

Could you (Varner) post a new patch with these changes? I'd then
test it some time next week and apply it unless xsteve vetoes it.

  • application/pgp-signature attachment: stored
Received on Sat Jul 9 01:07:14 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.