[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15282 - in trunk/subversion: clients/cmdline

From: Joshua Varner <jlvarner_at_gmail.com>
Date: 2005-07-07 15:28:49 CEST

On 7/6/05, kfogel@tigris.org <kfogel@tigris.org> wrote:
> Author: kfogel
> Date: Wed Jul 6 23:16:13 2005
> New Revision: 15282
>
<snip>
>
==============================================================================
> --- trunk/subversion/clients/cmdline/util.c (original)
> +++ trunk/subversion/clients/cmdline/util.c Wed Jul 6 23:16:13 2005
> @@ -545,7 +545,7 @@
> else /* non_interactive flag says we can't pop up an editor, so error */
> {
> return svn_error_create
> - (SVN_ERR_CL_NO_EDITOR_WHEN_NONINTERACTIVE, NULL,
> + (SVN_ERR_NONINTERACTIVE, NULL,
> _("Cannot invoke editor to get log message "
> "when non-interactive"));
> }
>
I may be missing something, but why isn't this check occuring at line 478:
  while (! message)
    {
      /* We still don't have a valid commit message. Use $EDITOR to
         get one. Note that svn_cl__edit_externally will still return
         a UTF-8'ized log message. */

This whole loop is exists to invoke the editor, so why enter it at all
if in interactive mode?
Then if that's the case shouldn't the error be either
SVN_ERR_REPOS_BAD_ARGS or SVN_ERR_CL_MUTUALLY_EXCLUSIVE_ARGS, since
specifying non-interactive without specifying a commit message on the
command line is the error. Or maybe a new error
SVN_ERR_CL_REQUIRED_ARGS_MISSING.

<snip>

TIA,
Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 7 15:29:55 2005

This is an archived mail posted to the Subversion Dev mailing list.