[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15277 - in trunk/subversion: clients/cmdline

From: <kfogel_at_collab.net>
Date: 2005-07-07 04:13:44 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:
> kfogel@tigris.org writes:
> > +/* Options for giving a log message. (Some of these also have other uses.)
> > + *
> > + * In theory, we should include svn_cl__non_interactive_opt here too,
> > + * because all the log-message-taking commands have the potential to
> > + * pop up an editor, and svn_cl__non_interactive_opt is the way to
> > + * prevent that. But so far, any command that includes these options
> > + * also includes SVN_CL__AUTH_OPTIONS, which of course already
> > + * contains svn_cl__non_interactive_opt, so we get it for free.
> > + */
> > #define SVN_CL__LOG_MSG_OPTIONS 'm', 'F', \
> > svn_cl__force_log_opt, \
> > svn_cl__editor_cmd_opt, \
>
> Sorry for asking the obvious questions, but did you attempt to see if
> adding svn_cl__non_interactive_opt here actually had negative side
> effects, like, the option showing up twice in the output, or whatnot?

Yep, I did try it, and it does show up twice.

> I mean, if duplicates in the allowed options list don't cause bad
> behavior, then SVN_CL__LOG_MSG_OPTIONS can become the expected thing.
> If duplicates don't work correctly, then let's evaluate the cost of
> making them work correctly. (Do you detect yet that I'm not liking
> this particular instance of "document around the situation"?)

I'm not bothered enough by the "document around it" solution to make
the larger change you're talking about, but I wouldn't stand in
anyone's way either...

(Thanks for the review, btw!)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 7 05:01:43 2005

This is an archived mail posted to the Subversion Dev mailing list.