[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Issue #2291 - 'svn ls -v' should return locking information - V3

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-07 00:12:14 CEST

Alexander Thomas wrote:
> Version 3 of the patch for fixing Issue #2291.

Thanks - this log message is much better.

>
> [[[
> Fix issue #2291: 'svn ls -v' should return locking information.
>
> * subversion/include/svn_types.h
> (svn_dirent2_t): New struct.
> (svn_dirent_t): Deprecated and moved to group it with new struct.
>
> * subversion/libsvn_ra_local/ra_plugin.c
> (svn_ra_local__get_dir): Gets lock information and moved towards
> the end to avoid compile time warning.

The warning isn't the ultimate reason why this needed to be moved; the warning
is simply the mechanism that alerted you to the fact that it needed to be
moved. Try to say why it really needed to be moved - e.g. because it now
depends on a function that was declared later. Maybe something like, "moved to
after the locking functions because it now calls them."

[...]
> * subversion/libsvn_ra_svn/client.c
> (ra_svn_get_dir): Gets lock information and moved towards the end
> to avoid compile time warning.

Ditto.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 7 00:13:10 2005

This is an archived mail posted to the Subversion Dev mailing list.