[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: issue #2264 - multiple locks over ra_svn - v4

From: <kfogel_at_collab.net>
Date: 2005-07-06 19:50:22 CEST

VK Sameer <sameer@collab.net> writes:
> > Mixture of space-before-paren and no-space-before-paren styles (in
> > function calls, I mean). This inconsistency is going on throughout
> > the patch, actually, but since the predominant style of the file seems
> > to be no-space, just go with that.
>
> OK. I should mention, though, the patch contains the inconsistencies
> because of copy-n-paste from other functions. I would have made changes
> to ra_svn_(un)lock_compat(), but didn't to avoid changes not related to
> the issue in the patch.

Well, I'm not proposing that you fix space-before-paren
inconsistencies in existing code -- as you say, that's not part of
this change. But when you cut and paste code to a new place, then fix
any inconsistencies in the new place! Cutting and pasting is merely
an editing convenience for you; you're still the author of the new
code, and there is no reason to preserve formatting problems inherited
from the code's original source.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 6 20:38:20 2005

This is an archived mail posted to the Subversion Dev mailing list.