Re: Guaranteeing memory pool lifetime

On Tue, 2005-07-05 at 20:41 +0100, Matthew Hambley wrote:
> > And how would you access the same map in subsequent calls?
>
> Hold the hash as a static variable and call the function which contained it
> to retrieve the pointer.

Static variables are not thread-safe, and we cannot protect them with a
mutex because we do not have statically initialized mutexes. We went
through this issue with character-set mappings and wound up with a new
function svn_utf_initialize() and poor performance if you don't call it.

The right answer is to create a context for MIME type mappings and make
the calling code pass the context to the guessing functions. We
couldn't do that for character set translations because it would have
required churning almost our entire code base, but MIME type guessing is
probably only done in a few places.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 5 22:33:24 2005