Re: [PATCH] Move authz access control to libsvn_repos

On Sun, 2005-07-03 at 19:10 +0200, David Anderson wrote:
> As I'm using svn_config_read(), which requires a file path, I create the
> temp file with apr_file_mktemp() write the contents using
> apr_file_write_full(), then get the path to read back using
> apr_file_name_get(). The temp file is closed (and deleted) as soon as
> the readback is complete. Is this satisfactory?

Yes, that's fine.

> > * I think we generally put two spaces after sentence-ending periods in
> > log messages and doc strings. (Except when it's the end of a comment,
> > in which case one space before the "*/" is fine.) You're only putting
> > one space after them.
>
> Fixed. Unless I missed it, this isn't in HACKING. Should it be?

Perhaps. I'm not sure if we can specify *everything* there.

> As I couldn't find any test framework for mod_authz_svn, I simply loaded
> the trunk mod_dav_svn and mod_authz_svn into my Apache2 and manually
> queried a greek tree repository in a way to trigger each of the authz
> test cases that are tested in repos-test.c.

That's fine, thanks.

> Here goes again!

Found a couple more formatting nits, but I can correct those myself:

+typedef enum
+ {

We don't generally indent the braces around type declarations.

+ for(i = 0; test_set[i].path != NULL; i++)

Missing space here.

+ /* If the 'user' is a subgroup, recurse into it */

Sentence, should end with a period.

+ /* Non-anon rule, anon user. Stop. */
+ /* User rule for wrong user. Stop. */

Two spaces after period. There were some other instances of this as
well.

I've made these changes and committed your patch as r15242.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 3 23:24:43 2005