Re: A proposed solution for svn admin directory names

Joseph Galbraith <galb@vandyke.com> writes:

> Garrett Rooney wrote:
>> Static variables like that are not especially thread safe.
>
> Ahh... I think my second code snippet address this problem
> as it does away with the bool and only uses the szAdmDir...
> I'll quote it here for clarity:
>
> char* getadmdir()
> {
> static char* szAdmDir = 0;
> if ( szAdmDir == 0 )
> {

Pointers are probably atomic on all the platforms that run Subversion,
but strictly speaking it's not guaranteed and depends on the platform.

> szAdmDir = ::getenv("SVN_ADM_DIR");
> if ( szAdmDir == 0 )
> szAdmDir = ".svn";
> }
>
> return szAdmDir;
> }

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org