Re: A proposed solution for svn admin directory names

Ben Collins-Sussman wrote:
>
> On Jun 29, 2005, at 10:51 AM, Jonathan Malek wrote:
>
>>
>> #define SVN_WC_ADM_DIR_NAME ( ( getenv( "SVN_ADM_DIR") ) ? ( getenv(
>> "SVN_ADM_DIR") ) : (".svn") )
>>
>> Thanks for taking the time to look at this Ben--I know it's been
>> hashed and rehashed, but I think this is a simple solution that works.
>
> The 'cons' of this proposal previously were based on the assumption
> that making the value of SVN_ADM_DIR into a runtime option would have
> involved using ~/.subversion/config, which would have been a huge
> coding change. But now it seems like a tweak to the already existing
> #define will accomplish the same task.
>
> The only other 'con' listed was that ASP.NET working copies would be
> non-portable. But frankly, that's the world we already live in. There
> are already lots of shops out there using 'special' TortoiseSVN builds
> which use '_svn' directories. So from where I stand, this proposal
> seems like a net gain. Nothing gets any worse, but it means Tortoise
> can stop making special releases.
>
> IANTSP -- "I am not the subversion project". Do any other developers
> have opinions about this?

Well, changing that define would break the compatibility (source, not
binary), so it would have to wait until 2.0 ?

Example:
On Windows, it's common to use the _T() macro for UNICODE strings. And
every program using the SVN_WC_ADM_DIR_NAME define inside such a _T()
macro would fail to build!

So, I suggest introducing something like

#ifdef ADMIN_DIR_CONFIGURABLE
# define SVN_WC_ADM_DIR_NAME (( getenv( "SVN_ADM_DIR") ) ? (
getenv("SVN_ADM_DIR") ) : (".svn") )
#else
# define SVN_WC_ADM_DIR_NAME ".svn"
#endif

and then let the client decide which one to use by setting the define
ADMIN_DIR_CONFIGURABLE accordingly.

Of course, if source compatibility isn't important, changing the define
wouldn't hurt much - some simple changes in the source will do to make
it compile again.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org