[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Crash in svn_client_switch()

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-06-23 20:28:43 CEST

SteveKing <steveking@gmx.ch> writes:

> another crashreport sent for TSVN, but happens actually in the
> Subversion lib:
>
> svn_client_switch() (switch.c: line 154)
> svn_wc_crawl_revisions2() (adm_crawler.c: line 489)
>
> The reason for the crash:
> the line 489 in adm_crawler.c reads
> base_rev = parent_entry->revision;
> and 'parent_entry' is NULL.
>
> The 'parent_entry' should be set in svn_wc_entry(), but obviously it
> isn't and no error is returned.

svn_wc_entry documents when NULL will be returned, it's not an error.

The question (as always) is how do you trigger this crash. Can you
describe the working copy state and the switch parameters? If we
decide to trap the NULL, which looks like a reasonable thing to do to
me, then I guess we simply return an ENTRY_NOT_FOUND error which means
the switch will fail.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 23 20:29:56 2005

This is an archived mail posted to the Subversion Dev mailing list.