[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] check name svn special properties

From: Fabien COELHO <fabien_at_coelho.net>
Date: 2005-06-23 14:41:44 CEST

>> Please find attached a patch which checks the name of svn special
>> properties and refuses unexpected ones. The check are performed in the
>> client library, where it seems to belong. The error can be overridden
>> with --force if necessary.
>>
>> The new feature is tested in the regression stuff. I had to remove 6
>> lines of some tests which were setting invalid svn special properties,
>> which are
>> now forbidden by default.
>
> Absence of log message makes this patch very hard to review.

Well, I intended the mail content to be an explanation. The patch is quite
short.

> What happens when an older client has to commit a newly-invented
> property? Say, after this patch is applied, we later invent a new
> property "svn:foobar", and someone wants to use that without upgrading
> their client?

The idea is that it is forcable, so it can be done anyway.

> I think having to use --force would be annoying...

Hummm.

I've been *really* annoyed by mispelled properties in the past, e.g.
svn:external, svn:ingore, svn:keyword...

The 'one new svn property was added the client was not upgraded and the
user wants to use it' looks like a rare case, which is easily solved by a
--force.

The next level is to have a new 'special' property that would list the
allowed property names, a little bit like svn:ignore, and could be fetched
by the client. But it seems as a lot of work for a small problem.

Have a nice day,

-- 
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 23 14:44:48 2005

This is an archived mail posted to the Subversion Dev mailing list.