[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Stack Trace for Ruby Segfaults

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-06-22 17:44:45 CEST

Hi,

In <df2177af050621205544b5255a@mail.gmail.com>
  "Re: Stack Trace for Ruby Segfaults" on Tue, 21 Jun 2005 23:55:12 -0400,
  David James <james82@gmail.com> wrote:

> > I think the problem can be fixed the patch at
> > http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=101652
> >
> > Could you try the patch?
>
> I am very happy to say that your patch solves my segfault problem.

OK, I committed. (r15138)

> With your patch, I managed to run the "test_authentication" test over
> 20 times without errors. Without your patch, the "test_authentication"
> test crashes about 25% of the time.

If you apply the attached patch, you'll meet segmentation
fault each time. :p
# This is caused by ruby's GC.

--
kou

Index: subversion/bindings/swig/ruby/svn/client.rb
===================================================================
--- subversion/bindings/swig/ruby/svn/client.rb (revision 15144)
+++ subversion/bindings/swig/ruby/svn/client.rb (working copy)
@@ -222,13 +222,14 @@
           cred
         end
         pro = Client.__send__("get_#{name}_prompt_provider", real_prompt, *args)
- @prompts << real_prompt
+ # @prompts << real_prompt
         @providers << pro
         update_auth_baton
       end
 
       def update_auth_baton
         self.auth_baton = Core::AuthBaton.open(@providers, @pool)
+ GC.start
       end
 
       def normalize_path(paths)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 22 17:45:39 2005

This is an archived mail posted to the Subversion Dev mailing list.