[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] check name svn special properties

From: Fabien COELHO <fabien_at_coelho.net>
Date: 2005-06-22 17:08:39 CEST

Dear Michael,

>> Please find attached a patch which checks the name of svn special
>> properties and refuses unexpected ones. The check are performed in the
>> client library, where it seems to belong. The error can be overridden
>> with --force if necessary.
>
> Because pset already accepts --force, are you concerned that a user
> passing --force for whatever other reason could also force the setting
> of an invalid svn: property? I think I'm fine with that, but figured
> I'd put it out there just in case.

I noticed, but I thought that if you say '--force', it means you really
want it, whatever it is. Also '--force' is often on second try after a
first failure. I did not see the need for a new separate option for such a
small thing.

> Also, any plans to expand the patch to also cover properties set via
> the auto-props functionality (used in 'svn add' and 'svn import')?

No plan at the time.

Most problems I saw with mispelled props where with manual pset.

I think auto-props are less likely to be mispelled, but it might be good
to check for them as well. I'll might look into it later. It might be
added to the "TODO" list in the meantime?

-- 
Fabien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 22 17:11:02 2005

This is an archived mail posted to the Subversion Dev mailing list.