[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn trunk r15103: FAIL (x86_64-unknown-linux-gnu shared ra_local bdb)

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-06-20 14:50:50 CEST

On Sun, 19 Jun 2005, Philip Martin wrote:

> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>
> > Ouch! How could I miss that? A missing SVN_ERR (err). I'll fix tomorrow
> > morning.
>
> That's not enough, checkout will fail, yes checkout! If the file is
> unversioned the new code gets SVN_ERR_ENTRY_NOT_FOUND but only handles
> ENOENT.
>
I choose a litle different approach (see r15116). The point is to optimize
the common case where timestamps are the same. The other cases are slow
anyway and an extra stat can't be measurable.

And Karl, I tried to describe the importance of the error codes in a
comment.

Thanks for clarifying the situation,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 20 14:51:53 2005

This is an archived mail posted to the Subversion Dev mailing list.