[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Cleanup leftover Ruby test repositories

From: David James <james82_at_gmail.com>
Date: 2005-06-20 04:59:28 CEST

On 6/19/05, Max Bowsher <maxb@ukf.net> wrote:
> The comment:
> +# Remove any leftover test repositories
> is a little redundant, IMO.
Good point -- I've removed it.

> Apart from that, my only complaint is that the change cleans wcs as well as repositories, and should be named appropriately - just
> drop the "-repos" part from the make rule name, and tweak the log message.
Done. That looks much better!

> Then, if it works fine for you, I think it is sufficiently localised to be considered part of your commit domain, despite touching a
> buildsystem file.
I was wondering about that -- thanks for the explanation! I'm glad I
sent this patch through the list first because your feedback was very
helpful.

Committed in r15112.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 20 05:00:01 2005

This is an archived mail posted to the Subversion Dev mailing list.