Re: svn trunk r15103: FAIL (x86_64-unknown-linux-gnu shared ra_local bdb)

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> On Sun, 19 Jun 2005 svntest@jaa.iki.fi wrote:
>
>> FAIL: stat_tests.py 13: timestamp behaviour
>> At least one test was SKIPPED, checking /svntest/obj-sh/tests.log
>> SKIP: utf8_tests.py 1: conversion of paths and logs to/from utf8
>> make: *** [check] Error 1
>> Complete log saved in /srv/svntest/svntest/logs/svn_trunk/LOG_svn_check_shared_ra_local_bdb.15103.failed
>> FAIL: make check
>
> Might this be my work on status that broke this? Jani (or anyone else),
> do you have time to investigate? It passes on my system.

Valgrind reports this:

CMD: svn "co" "--username" "jrandom" "--password" "rayjandom" "file:///home/pm/sw/subversion/obj/subversion/tests/clients/cmdline/svn-test-work/repositories/stat_tests-13" "svn-test-work/working_copies/stat_tests-13" "--config-dir" "/home/pm/sw/subversion/obj/subversion/tests/clients/cmdline/svn-test-work/local_tmp/config" <TIME = 14.317706>
==3282== Conditional jump or move depends on uninitialised value(s)
==3282== at 0x1B95CA63: svn_wc_text_modified_p (questions.c:408)
==3282== by 0x1B964919: install_file (update_editor.c:2040)
==3282== by 0x1B96554C: close_file (update_editor.c:2404)
==3282== by 0x1B975EBC: close_file (cancel.c:235)
==3282== by 0x1BD52B46: update_entry (reporter.c:669)
==3282== by 0x1BD53126: delta_dirs (reporter.c:791)
==3282== by 0x1BD529BB: update_entry (reporter.c:653)
==3282== by 0x1BD53126: delta_dirs (reporter.c:791)
==3282== by 0x1BD529BB: update_entry (reporter.c:653)
==3282== by 0x1BD53126: delta_dirs (reporter.c:791)
==3282== by 0x1BD5348E: drive (reporter.c:847)
==3282== by 0x1BD5386D: finish_report (reporter.c:908)

      if (err && APR_STATUS_IS_ENOENT(err->apr_err))
        {
          /* If the file doesn't exist, its considered non-modified. */
          svn_error_clear (err);
          *modified_p = FALSE;
          goto cleanup;
        }
      if (equal_timestamps)
        {
          *modified_p = FALSE;
          goto cleanup;
        }

If err != ENOENT then equal_timestamps might be uninitialised.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org