[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add documentation to tools/examples/svnlook.rb

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-06-16 08:34:15 CEST

Hi,

In <df2177af05061514571430146e@mail.gmail.com>
  "[PATCH] Add documentation to tools/examples/svnlook.rb" on Wed, 15 Jun 2005 17:57:03 -0400,
  David James <james82@gmail.com> wrote:

> This patch adds documentation to tools/examples/svnlook.rb.
>
> * tools/examples/svnlook.rb:
> (SvnLook): Added lots of documentation. Switched style of 'case'
> statements so that when/else statements are indented. Got
> rid of empty cmd_cat function. Add explicit return statements
> to improve clarity.

I accepted documentation, thanks. (r15069)
But I rejected the following.

  * 'case' indentation
    I don't like the indentation. I want to use indentation
    style of ruby-mode.el.
    
  * removing 'cmd_cat'

    I'll (maybe?) implement later.

  * adding 'return'
    
    I don't like using 'return'. (This is my style)

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 16 08:35:08 2005

This is an archived mail posted to the Subversion Dev mailing list.