[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15023 - branches/ebcdic/trunk/subversion/svnlook

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-06-15 01:30:43 CEST

pburba@tigris.org writes:

> Author: pburba
> Date: Fri Jun 10 14:35:27 2005
> New Revision: 15023
>
> Modified:
> branches/ebcdic/trunk/subversion/svnlook/main.c
>
> Log:
> Fix bug preventing svnlook against a transaction.
>
> * subversion/svnlook/main.c
> (get_ctxt_baton): Convert opt_state->txn to utf8 before storing in baton.
>
> Modified: branches/ebcdic/trunk/subversion/svnlook/main.c
> Url: http://svn.collab.net/viewcvs/svn/branches/ebcdic/trunk/subversion/svnlook/main.c?rev=15023&p1=branches/ebcdic/trunk/subversion/svnlook/main.c&p2=branches/ebcdic/trunk/subversion/svnlook/main.c&r1=15022&r2=15023
> ==============================================================================
> --- branches/ebcdic/trunk/subversion/svnlook/main.c (original)
> +++ branches/ebcdic/trunk/subversion/svnlook/main.c Fri Jun 10 14:35:27 2005
> @@ -1722,7 +1722,11 @@
> baton->full_paths = opt_state->full_paths;
> baton->is_revision = opt_state->txn ? FALSE : TRUE;
> baton->rev_id = opt_state->rev;
> +#if !APR_CHARSET_EBCDIC
> baton->txn_name = apr_pstrdup (pool, opt_state->txn);
> +#else
> + SVN_ERR (svn_utf_cstring_to_utf8 (&baton->txn_name, opt_state->txn, pool));
> +#endif
> if (baton->txn_name)
> SVN_ERR (svn_fs_open_txn (&(baton->txn), baton->fs,
> baton->txn_name, pool));

That's a bug on the trunk isn't it? The txn from the program's
argument list is getting passed to svn_fs_open_txn and yet it has
native encoding, not UTF-8. It should probably be converted in
main().

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 15 01:31:36 2005

This is an archived mail posted to the Subversion Dev mailing list.