[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15051 - in trunk: build/ac-macros subversion/include subversion/libsvn_ra_dav

From: <kfogel_at_collab.net>
Date: 2005-06-14 21:06:33 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:
> kfogel@tigris.org writes:
>
> > Modified: trunk/subversion/libsvn_ra_dav/commit.c
> > ==============================================================================
> > --- trunk/subversion/libsvn_ra_dav/commit.c (original)
> > +++ trunk/subversion/libsvn_ra_dav/commit.c Mon Jun 13 19:35:45 2005
> > @@ -211,6 +211,9 @@
> > /* run the request and get the resulting status code (and svn_error_t) */
> > SVN_ERR( svn_ra_dav__request_dispatch(code, req, ras->sess,
> > method, url, okay_1, okay_2,
> > +#if SVN_NEON_0_25_0
> > + NULL, NULL,
> > +#endif /* SVN_NEON_0_25_0 */
> > pool) );
>
> I'm not completely sure, but shouldn't this really be #ifdef instead
> of #if ?

One would think so, but it turns out there's a fallback behavior that
Does The Right Thing. Your review probably crossed my other mail in
the pipe; here's what I wrote:

> By the way, the fact that the r15051 conditional compilation guards
> use "#if" not "#ifdef" should be okay: any macro name remaining
> after expansion is replaced with 0L by the preprocessor, so if
> SVN_NEON_0_25_0 isn't defined at all, then all those conditionals
> should simply evaluate to false.

See also K&R p. 232.

(Thanks for the review, though.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 14 21:49:18 2005

This is an archived mail posted to the Subversion Dev mailing list.