[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BUG(?): "svn diff" behaves incorrectly on symbolic links pointing to binary files

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-06-14 04:05:18 CEST

kfogel@collab.net writes:

> "Wesley J. Landaker" <wjl@icecavern.net> writes:
>> Again a quick intro: I'm a Debian developer who is helping out with the
>> subversion packages. This bug was reported recently, and I thought I'd
>> forward it here for your thoughts:
>>
>> On Tue, 29 Mar 2005, Vincent Lefevre <vincent@vinc17.org> wrote:
>> > When I do a "svn diff" in a directory where a symbolic link has been
>> > added, Subversion does a diff on this link, even when the file pointed
>> > to is a binary file. The consequence is that these binary data are
>> > sent to the terminal (in my case, xterm). This had two very bad side
>> > effects:
>> >
>> > 1) The terminal was trashed (I had to do a "reset").
>> >
>> > 2) A part of the data was sent to the printer! I suppose that some
>> > escape sequence was interpreted as a request for printing.
>> >
>> > Note: I posted a message about this problem to the Subversion dev
>> > mailing-list on 25 Mar 2005, but I haven't got any reply yet.
>>
>> (Well, sorry if it's a repeat--I'm subscribed to this list, but I don't
>> remember any discussion about this issue.)
>
> I agree this is a bug.

Really? So what is the correct behaviour? Are you suggesting that
the client uses the svn:mime-type of the link destination rather than
the link itself? What happens if the destination is not versioned?

How did you reproduce the bug anyway?

$ svnadmin create repo
$ svn co file://`pwd`/repo wc
Checked out revision 0.
$ cp /bin/ls wc/dst
$ svn add wc/dst
A (bin) wc/dst
$ ln -sf dst wc/src
$ svn add wc/src
A wc/src
$ svn diff wc
Index: wc/src
===================================================================
--- wc/src (revision 0)
+++ wc/src (revision 0)
@@ -0,0 +1 @@
+link dst
\ No newline at end of file

Property changes on: wc/src
___________________________________________________________________
Name: svn:special
   + *

Index: wc/dst
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on: wc/dst
___________________________________________________________________
Name: svn:executable
   + *
Name: svn:mime-type
   + application/octet-stream

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 14 04:07:21 2005

This is an archived mail posted to the Subversion Dev mailing list.