[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15016 - trunk/subversion/libsvn_fs_fs

From: Tobias Ringström <tobias_at_ringstrom.mine.nu>
Date: 2005-06-10 20:01:47 CEST

lundblad@tigris.org wrote:

>Modified: trunk/subversion/libsvn_fs_fs/fs_fs.c
>Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_fs_fs/fs_fs.c?rev=15016&p1=trunk/subversion/libsvn_fs_fs/fs_fs.c&p2=trunk/subversion/libsvn_fs_fs/fs_fs.c&r1=15015&r2=15016
>==============================================================================
>--- trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
>+++ trunk/subversion/libsvn_fs_fs/fs_fs.c Thu Jun 9 16:29:10 2005
>@@ -2023,7 +2023,7 @@
> old_change->text_mod = change->text_mod;
> old_change->prop_mod = change->prop_mod;
> if (change->copyfrom_rev == SVN_INVALID_REVNUM)
>- copyfrom_string = NULL;
>+ copyfrom_string = apr_pstrdup (copyfrom_pool, "");
> else
> {
> copyfrom_string = apr_psprintf (copyfrom_pool,
>@@ -2062,7 +2062,7 @@
> change->copyfrom_path);
> }
> else
>- copyfrom_string = NULL;
>+ copyfrom_string = apr_pstrdup (copyfrom_pool, "");
> path = apr_pstrdup (pool, change->path);
> }
>
>
>
>
Thanks for fixing my error, Peter, but may I suggest that you don't put
the old (weird) strdup of the empty string back in. Just do

    copyfrom_string = "";

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 10 20:04:13 2005

This is an archived mail posted to the Subversion Dev mailing list.