Re: [PATCH] Issue #869 - import should use .svn area to get props

>
>
> + If a directory being imported is already a WC, then:
>
> + Import the directory with its existing properties (including
> svn:externals).
>

Properties on directories including svn:externals are also added.

> + For each child that is versioned, import it with its existing
> Subversion
> properties, without invoking any of the heuristic rules that would
> otherwise have been used to set properties such as svn:mime-type and
> svn:executable.
>

Need to check this - the patch uses svn_client_proplist2() to find
props - svn:mime-type could be skipped since 'svn import' in any
case heuristically sets this property.

> + Use the directory's svn:ignore property (as well as the global
> ignores) to
> determine which unversioned files to ignore.

No, the patch does not use a directory's svn:ignore to determine
which unversioned files to ignore.

>
> + For each unversioned child to be imported, use the normal "import"
> rules.
>

Normal import rules ? Is there a contradiction between the last
requirement and the previous one about using a directory's
svn:ignore to ignore unversioned files.

I will modify the patch to (a) skip importing svn:mime-type and
possibly svn:executable ( don't remember otoh if import heurestically
sets the latter as well) (b) honor the svn:ignore's on dirs

Thanks for the review.
Ramaswamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 9 21:31:58 2005