[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Unexpected behavior from psvn.el

From: Joshua Varner <jlvarner_at_gmail.com>
Date: 2005-06-08 21:51:06 CEST

I was adding svn:ignore properties to my project and wanted to check
those in, but there were some other local changes that i didn't want
commited. So using psvn.el I marked the directories (which
automatically marks any changed files under that directory), then
unmarked those changed files and ran the commit. To my surprise the
unmarked changed files were committed anyway.

After digging a little I saw what was needed was a -N to avoid the
recursion, but there was no way to do that in psvn. But i realized
that since marking automatically selects all the files under a
directory anyway, all of those files should be explicitly listed on
the command. So the only time you would have a directory marked but
not a file under it is if you explicitly unmarked the file.

So what i'm trying to say in a rambling manner, is that I think -N
should be default for psvn. I tested the normal case (when you want
the files under a directory committed and as long as they are marked
this change functions the same as before). Patch below


  psvn.el(svn-log-edit-done) Added -N to commit command

Index: psvn.el
--- psvn.el (revision 15011)
+++ psvn.el (working copy)
@@ -2965,7 +2965,7 @@
       (svn-status-create-arg-file svn-status-temp-arg-file ""
                                   svn-status-files-to-commit "")
       (svn-run-svn t t 'commit "commit" "--targets" svn-status-temp-arg-file
- "-F" svn-status-temp-file-to-remove))
+ "-N" "-F" svn-status-temp-file-to-remove))
     (set-window-configuration svn-status-pre-commit-window-configuration)
     (message "svn-log editing done")))

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 8 21:52:33 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.