Re: svn commit: r15001 - in trunk/subversion: include libsvn_client libsvn_wc

Philip Martin wrote:
> julianfoad@tigris.org writes:
>>Fix issue #2243: make 'svn add' honor svn:ignore property.
>
>>+def basic_add_local_ignores(sbox):
>
> This sets svn:ignore on the directory:
>
> svn-test-work/working_copies/basic_tests-24
>
> This adds the directory
>
> svn-test-work/working_copies/basic_tests-24/dir
>
> This checks that the file:
>
> svn-test-work/working_copies/basic_tests-24/dir/app.lock
>
> did not get added.

Oh dear. Sorry. I completely failed to test this by hand or to check the
regression test.

> svn:ignore on "basic_tests-24" does not normally affect files in
> "basic_tests-24/dir/", but it appears that svn:ignore has been made
> recursive in this case. After running the test "svn status" shows

Actually the patch is not recursive but is honouring the grandparent's
svn:ignore property rather than the parent's, but anyway it's wrong.

I'm fixing it.

Thanks for noticing.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 7 22:10:13 2005