[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15001 - in trunk/subversion: include libsvn_client libsvn_wc

From: <kfogel_at_collab.net>
Date: 2005-06-07 19:21:43 CEST

julianfoad@tigris.org writes:
> --- trunk/subversion/include/svn_wc.h (original)
> +++ trunk/subversion/include/svn_wc.h Tue Jun 7 11:38:36 2005
> @@ -2974,6 +2974,18 @@
> apr_hash_t *config,
> apr_pool_t *pool);
>
> +/** Get the list of ignore patterns from the @c svn_config_t's in the
> + * @a config hash and the local ignore patterns from the directory
> + * in @a adm_access, and store them in @a *patterns.
> + * Allocate @a *patterns and its contents in @a pool.
> + *
> + * @since New in 1.3.
> + */
> +svn_error_t *svn_wc_get_ignores (apr_array_header_t **patterns,
> + apr_hash_t *config,
> + svn_wc_adm_access_t *adm_access,
> + apr_pool_t *pool);
> +

Does this mean that svn_wc_get_default_ignores() should be deprecated
now, and its doc string should recommend svn_wc_get_ignores instead?

> --- trunk/subversion/libsvn_wc/status.c (original)
> +++ trunk/subversion/libsvn_wc/status.c Tue Jun 7 11:38:36 2005
> @@ -520,7 +520,7 @@
> None of the arguments may be NULL.
> */
> static svn_error_t *
> -collect_ignore_patterns (apr_array_header_t *patterns,
> +collect_ignore_patterns (apr_array_header_t **patterns,
> apr_array_header_t *ignores,
> svn_wc_adm_access_t *adm_access,
> apr_pool_t *pool)
> @@ -528,11 +528,13 @@
> int i;
> const svn_string_t *value;
>
> + *patterns = apr_array_make (pool, 1, sizeof (const char *));
> +
> /* Copy default ignores into the local PATTERNS array. */
> for (i = 0; i < ignores->nelts; i++)
> {
> const char *ignore = APR_ARRAY_IDX (ignores, i, const char *);
> - APR_ARRAY_PUSH (patterns, const char *) = ignore;
> + APR_ARRAY_PUSH (*patterns, const char *) = ignore;
> }

Why do we even have collect_ignore_patterns() anymore? Shouldn't its
code just go into svn_wc_get_ignores(), and the one other caller of
collect_ignore_patterns() would just be adjusted to call
svn_wc_get_ignores() instead?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 7 20:03:47 2005

This is an archived mail posted to the Subversion Dev mailing list.