[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_cl__try

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-06-06 21:20:57 CEST

On Mon, 6 Jun 2005 vivek@collab.net wrote:

> Hi all,
> The variadic function svn_cl__try in
> subversion/clients/cmdline/util.c has a parameter 'success' which may not
> always be of use to the caller. This is the case with proplist-cmd.c file
> where the passed parameter is named ignored_success.
> If only svn_cl__try had tested NULL before setting success, we
> could have avoided the use of the 'ignored_success' variable.

+1 to fix this. (I'd do it myself, but currently my WC has another patch
under development.)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 6 21:11:57 2005

This is an archived mail posted to the Subversion Dev mailing list.