[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] operation logging

From: <kfogel_at_collab.net>
Date: 2005-06-06 04:24:47 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> Well, the obvious criticisms are:
>
> * Operations from 1.0 and 1.1 clients won't be logged. Having an
> incomplete log isn't very satisfying.

Yes, but there is no way around that, given the impossibility of
deducing operations reliably given the information 1.0 and 1.1 send
over the wire.

We could add a feature whereby the server has the option to reject
clients who don't declare that they intend to abide by the logging
protocol. That would address the problem, albeit in a somewhat
draconian manner ("Upgrade or you can't use our repository!").

> * You haven't solved the problem of how to log, say, a commit over DAV
> once. You'll wind up logging it once for each HTTP operation involved
> in the commit. For your patch this is no problem, since you're just
> annotating the pre-existing HTTP log information, but for a generic
> logging mechanism your proposal seems incomplete.

Yes, we have solved that problem, that's the whole point :-). The
logging is per client operation, not per HTTP operation. Each commit
gets logged once, no matter how many paths / HTTP operations were
involved.

(Well, actually there's a bug whereby each commit gets logged twice,
the second time with an empty path, but that's irrelevant here; Ben
and I already know about it and will of course fix it.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 6 05:05:39 2005

This is an archived mail posted to the Subversion Dev mailing list.