[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2105 - Add '--no-ignore' option to 'svn add' and

From: S.Ramaswamy <ramaswamy_at_collab.net>
Date: 2005-06-04 05:22:15 CEST

>
> You haven't mentioned the file "add-cmd.c".
>

Oops, will fix it

>>
>> - if (svn_cstring_match_glob_list (this_entry.name, ignores)) +
>> if ((!no_ignore) && svn_cstring_match_glob_list (this_entry.name, +
>> ignores))
>
> Indentation.

Line up "ignores" with "this_entry.name" in the prev. line or move
ignores to the beginning of the line ?

>
> You should update the template for the Subversion user-level "config"
> file as part of your patch, as it presently says:
>
> ### Set global-ignores to a set of whitespace-delimited globs
> ### which Subversion will ignore in its `status' output.
>
> which impies that "global-ignores" applies only to the "status"
> command.

Does this change look ok ?
Index: subversion/libsvn_subr/config_file.c
===================================================================
--- config_file.c (revision 14960)
+++ config_file.c (working copy)
@@ -1168,8 +1168,10 @@
         APR_EOL_STR
         "### Set global-ignores to a set of whitespace-delimited globs"
         APR_EOL_STR
- "### which Subversion will ignore in its 'status' output."
+ "### which Subversion will ignore in its 'status' output, and"
         APR_EOL_STR
+ "### while importing or adding files and directories."
+ APR_EOL_STR
         "# global-ignores = " SVN_CONFIG_DEFAULT_GLOBAL_IGNORES ""
         APR_EOL_STR
         "### Set log-encoding to the default encoding for log messages"

Thanks for the review again.

Ramaswamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 4 05:27:36 2005

This is an archived mail posted to the Subversion Dev mailing list.