[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14968 - branches/server-l10n/subversion/libsvn_ra_dav

From: Jani Averbach <jaa_at_jaa.iki.fi>
Date: 2005-06-04 00:31:11 CEST

On 2005-06-03 16:01-0500, dlr@tigris.org wrote:
> Author: dlr
> Date: Fri Jun 3 16:01:29 2005
> New Revision: 14968
>
> Modified:
> branches/server-l10n/subversion/libsvn_ra_dav/util.c
>
> Log:
> * subversion/libsvn_ra_dav/util.c
> (parsed_request): LC_MESSAGES isn't available on Windows, but we
> could use LC_ALL when calling setlocale() there. However, Windows
> and some Linux may return friendly aliases for the language and
> country codes, which do not appear to be permitted per section 3.10
> of RFC 2616. ifdef'd out sending of Accept-Language on Windows
> (general solution in the works). Duplicate the return value of
> setlocale(), since we'll be manipulating that memory (and it could
> be read-only).

As from lurker's point of view, should this explanation be located on
the code instead of the commit message?

BR, Jani

-- 
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 4 00:55:05 2005

This is an archived mail posted to the Subversion Dev mailing list.