On Fri, 2005-06-03 at 11:13 -0400, John Peacock wrote:
> It should be sufficient to just store a flag noting the *presence* of a
> svn:keywords in the entries files. Right now you only want to have
> $URL$ and possibly $GlobalRevision$ get autoexpanded; later there might
> be others and it is easy to retrieve the actual svn:keywords value after
> locating which files need special handling...
That doesn't seem right. If we just flag the presence of svn:keywords,
then we have to read the props of every keyword-enabled file in the
working copy after every switch (and every update, for the global
revision keyword). That's substantially slower than what we do now,
which is just read and rewrite the rev files.
If we store the value, then we only have to do extra work for files
which use the offending keywords (GlobalRevision for update, URL and
GlobalRevision for switch).
Of course, storing the keywords value in the entries file is itself a
cost. It's not a very big cost intrinsically, but I'm not sure if we
are in a good position to know the keywords value every time we write an
entry, and it would be a shame to add more rewriting of entries for this
purpose.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 3 17:31:17 2005