[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14921 - in trunk: subversion/clients/cmdline subversion/clients/cmdline/dtd tools/client-side

From: <kfogel_at_collab.net>
Date: 2005-06-02 16:30:34 CEST

"Peter N. Lundblad" <peter@famlundblad.se> writes:
> Also, this issue has been around for some time and the patch have
> circulated six times on the mailing list. If you have objections to the
> functionality - adding xml output to status - IMO it makes much more sense
> to raise those objections earlier in the process than after the commit and
> I'm actually getting a little annoyed by it. I'm not saying it's too late
> to revert this work and if others dislike it, that will be done of course.
> But it's not like this feature has been implemented invissibly in any way.

Hey Peter,

I agree with everything you said about it how this code already serves
a useful purpose even without further enhancements, and how it's easy
to improve on it now that it's in Subversion. However, I think in the
above paragraph you might be asking for something unrealistic.

Sure, ideally everyone would make their comments before a patch goes
in, especially when it's been circulating as long as this one has.

But in fact, no one has time to watch every iteration of every patch.
To deal with this, we have (unconsciously) adopted a pretty effective
divide-and-conquer approach: for each patch undergoing review, there
are one or two people paying close attention and giving detailed
feedback. When the patch is committed, it has passed that first, most
important level of filtering, so now other people start to look more
closely at it, offering comments and suggestions. They invest the
time now because it has become clear that the investment is worth it.
The patch has already been cleaned up of obvious bugs and problems,
and it's in the core code.

Don't think of the commit as a static, final event in the lifecycle of
the patch. Think of it as another turn of the review loop -- but a
special turn, one that serves as a signal to those who have been
sitting on the sidelines: "Now is your moment, go take a closer look,
because the best time to fix any remaining problems is when the code
is fresh and hasn't yet grown dependencies."

So please don't be annoyed. You did a great service by paying close
attention to this patch from the beginning, but that doesn't mean it's
wrong for others to start paying attention now.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 2 17:34:49 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.