[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Review of patch in issue #2301 (test for -rDATE with diff).

From: Vivek <vivek_at_collab.net>
Date: 2005-06-02 06:26:47 CEST

On Wed, 2005-06-01 at 03:22, kfogel@collab.net wrote:
> I don't have the original post handy, but here is a review of the
> patch attached to issue #2301.

This was posted sometime back. :-)
>
> Please leave a comma after the last element, so the next diff can
> affect only one line instead of two. (It should have been this way
> before, I don't know why it was not.)

Thanks for the detailed review Karl. I did this patch as a test case for
the GNU date/time bug. Is going for a V2 worth it?
And Thanks for committing patch of issue #2300.

Vivek.
>
> -Karl
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 2 06:26:43 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.