[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2105 - Add '--no-ignore' option to 'svn add' and 'svn import' (v4)

From: <kfogel_at_collab.net>
Date: 2005-06-02 05:07:21 CEST

Julian Foad <julianfoad@btopenworld.com> writes:
> > - * ### kff todo: This import is similar to cvs import, in that it does
> > - * not change the source tree into a working copy. However, this
> > - * behavior confuses most people, and I think eventually svn _should_
> > - * turn the tree into a working copy, or at least should offer the
> > - * option. However, doing so is a bit involved, and we don't need it
> > - * right now.
>
> You have removed that "to do" comment without mentioning the fact or
> doing what it suggests. Presumably you removed it just because you
> think the comment is not useful - it can be represented better by an
> issue in the issue tracker. Removing it is not really related to the
> rest of this patch. I think that's OK, but just wanted to check that
> this is why you removed it, and it wasn't that you thought you had
> done what it suggests.
>
> Oh ... Now I have seen an earlier message where Karl says to you,
> "Ouch, how painful to see that "todo" there :-) ." I think Karl was
> just expressing how he is sorry that that feature has not yet been
> implemented. He didn't mean that you should remove the comment.

That's exactly right. Sorry for not being extra clear about it.

By the way, I agree about changing the parameter names to 'ignore' and
reversing their sense. Almost said that myself, and then I thought
"No, that's too fussy." But you're right, it would be better.

> > Index: subversion/tests/clients/cmdline/import_tests.py
> > ===================================================================
> [...]
> > + if not match:
> > + ### we should raise a less generic error here. which?
>
> Ask questions like this on the mailing list, or get rid of the "###"
> comment if it has been answered.
>
> > + raise svntest.Failure
> [...]

I think by putting the "###" in a comment in a patch posted for
review, he effectively *is* asking the question on the mailing list :-).

(I agree it should no go into the final commit, of course.)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 2 05:47:10 2005

This is an archived mail posted to the Subversion Dev mailing list.