[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix svn cat to skip unversioned items V3.

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-31 21:53:06 CEST

On Tue, 31 May 2005 kfogel@collab.net wrote:

> "Peter N. Lundblad" <peter@famlundblad.se> writes:
> > > (If I could think of some way to make SVN_CL__TRY take an arbitrary
> > > number of errors to test for, that would be perfect. But variadic
> > > macros weren't added to C until C99, and even then they don't do quite
> > > what we'd need. Oh well.)
> >
> > We could always supply an array of extra errors to accept. Maybe the
> > avoidance of code duplication is worth it.
>
> I was thinking of that. Unfortunately, this being C, the overhead of
> setting up an array would be annoying. However, I thought of another
> way. Let's change SVN_CL__TRY() to a variadic function:
>
+1. There is no need for this to be a macro.

> > > Don't forget to check opt_state->quiet before calling
> > > svn_handle_warning(). We don't want to emit warnings if the user
> > > specified --quiet on the command line.
> >
> > Ha, that's my fault. I adviced against that since cat doesn't accept
> > --quiet. Maybe we want to add --quiet to cat for this case.
>
> Yes, I think we should (though that's somewhat a separate issue).
>
OK.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 31 21:45:21 2005

This is an archived mail posted to the Subversion Dev mailing list.