[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow 'svn proplist' to skip unversioned items (was: Re: inconsistency in handling of commandline parameters)

From: <kfogel_at_collab.net>
Date: 2005-05-30 20:45:56 CEST

"S.Ramaswamy" <ramaswamy@collab.net> writes:
> > On 2005-05-08 07:56:02 -0700, S.Ramaswamy wrote:
> >> Allow 'svn proplist' to skip unversioned files and continue.
> >>
> >> * subversion/clients/cmdline/proplist-cmd.c
> >> (svn_cl__proplist) : Test for SVN_ERR_UNVERSIONED_RESOURCE and
> >> continue
> >> with a warning if so.
> >
> > cool. :)
> >
> > what other commands should behave the same way?
> >
> > maybe: commit, blame,...?
> >
> > i think any command that can handle multiple items at the commandline
> > should use this logic?
> >
> > comments?
>
> Actually for issue #2030, Karl made a macro SVN_CL__TRY or somesuch that
> could be used if the only error to be skipped is
> SVN_ERR_UNVERSIONED_RESOURCE. Since for proplist, there is more than one
> one condition to be skipped I didn't use it.

In r14883, I took SVN_CL__TRY() and extended it for proplist.

SVN_CL__TRY() was only being used in two other places, and in both of
them it made sense to skip SVN_ERR_ENTRY_NOT_FOUND anyway.

Also, now propdel and propset can pay attention to opt_state->quiet
when skipping, which they should have been doing all along. See
r14883 for details.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 30 21:25:01 2005

This is an archived mail posted to the Subversion Dev mailing list.