[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: issue #2264 - multiple locks over ra_svn - v3

From: VK Sameer <sameer_at_collab.net>
Date: 2005-05-24 10:39:13 CEST

Brian W. Fitzpatrick wrote on 05/24/2005 10:50 AM:
> On May 23, 2005, at 11:16 PM, VK Sameer wrote:
>> Peter N. Lundblad wrote on 05/24/2005 02:15 AM:
>>> I think you could clean this up a little before a detailed review.
>>> There is some debugging printfs left in the code:-)
>> Whoops, sorry about that :( - need to do a more careful review of
>> the patch next time before sending it out. An updated patch is
>> attached.

Sigh, yet more debugging helper code removed. Also did a little cleaning
up of the whitespace.

>>> MOre importantly, I think it would be good if you started by a
>>> patch to libsvn_ra_svn/protocol. Then we can get the protocol
>>> extension right first.

Hrm, we'd put comments in the code describing the new commands. Updated
patch contains patch to libsvn_ra_svn/protocol as well.

> the ra_svn protocol has nothing to do with th ra_dav changes, so feel
free to provide a patch for the protocol document.

True, I wasn't thinking of the protocol file when I wrote that response.

>> While I have your attention, Peter ;) and others. Is the intent of
>> this extension to pass a set of paths (and revision numbers or other
>> associated data) end-to-end?
> I'm not Peter, but I can answer this. :)

But you're in the 'others' category :) - thank you for the answer.

> The intent of this change is to send the comment, owner and force flag
once, and a revnum and a path for each path to be locked or unlocked, and
to do it all in one server roundtrip. The existing code just makes a
bunch of roundtrips to the server, sending one lock at a time.

OK, I think the code as it stands does the above.

In an IRC discussion cmpilato suggested changing svn_repos_fs_lock and
svn_repos_fs_unlock to take multiple paths so that only the post-hook
script is run only once. Also, kfogel suggested adding a callback
function/baton pair which would append the path to the temp. file and
call the post-hook script only at the end of the list of paths to be
locked. Before I go off and make this complicated, any comments?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue May 24 10:42:54 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.