[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: issue #2264 - multiple locks over ra_svn

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-23 22:45:32 CEST

On Mon, 23 May 2005, VK Sameer wrote:

> Attached is a patch for issue #2264
> (http://subversion.tigris.org/issues/show_bug.cgi?id=2264).
>
> The scope of a batch send of multiple locks is confined to the ra_svn pipe.
> After marshalling and unmarshalling, locks are handled in a loop. FS and WC
> code have not been modified to handle multiple lock requests.
>
> Please feel free to pound on the patch, especially the error handling. This
> is the first time Vivek (vivek@collab.net) and I have worked on the ra_svn
> code and we have not stepped through many possible
> combinations in gdb.
>
I think you could clean this up a little before a detailed review. There
is some debugging printfs left in the code:-)

MOre importantly, I think it would be good if you started by a patch to
libsvn_ra_svn/protocol. Then we can get the protocol extension right
first.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 23 22:36:46 2005

This is an archived mail posted to the Subversion Dev mailing list.