[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2105 - Add '--no-ignore' option to 'svn add' and

From: S.Ramaswamy <ramaswamy_at_collab.net>
Date: 2005-05-20 12:20:09 CEST

> Just style and comment nits.

>
> when you add a new API, don't forget to add a line like the following:
> @since New in 1.3.
>
> It shouldn't occur first in the docstring, since then it will be
> treated as the short function description by doxygen. (We did it that
> way before an no one has done the ceeanup yet.)

>
> Same for @deprecated.
>
> Missing @since.
>
> Misplaced @deprecated.
>

ok, I will correct these in the next patch.

>
> this could be written more compactly with just one if statement (but it
> is mostly a matte of taste).
>
>> @@ -364,8 +366,11 @@
>> if (apr_hash_get (excludes, abs_path, APR_HASH_KEY_STRING))
>> continue;
>>
>> - if (svn_cstring_match_glob_list (filename, ignores))
>> - continue;
>> + if (!no_ignore)
>> + {
>> + if (svn_cstring_match_glob_list (filename, ignores))
>> + continue;
>> + }
>>
>
> Same nit here.
>

I originally had it as a single statement, the reason that was changed,
iirc, is 'svn_cstring_glob_list()' doesn't seem too happy with empty
ignores. When '--no-ignore' is specified the code does not to collect the
list of ignores.

>> /* We only import subdirectories when we're doing a regular
>> recursive import. */
>> @@ -441,9 +447,6 @@
>> * If CTX->NOTIFY_FUNC is non-null, invoke it with CTX->NOTIFY_BATON
>> for * each imported path, passing actions
>> svn_wc_notify_commit_added. *
>> - * EXCLUDES is a hash whose keys are absolute paths to exclude from -
>> * the import (values are unused).
>> - *
>
> why did you drop these lines?

No idea, will fix it.

I will send the revised patch separately.

Thanks
Ramaswamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 20 12:23:15 2005

This is an archived mail posted to the Subversion Dev mailing list.