[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: Log Message Templates via new hook.

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-05-20 02:12:19 CEST

> After more consideration, I think that disconnected accessibility to
> log message templates is not all that important. I'm not trying to
> mindlessly champion the RA/hook idea here -- I just want to point out
> how one suggested drawback is not actually much of a drawback.

I have previously raised a few points related to how this feature would
effect GUI tools that no one has addressed yet.

1) With many GUI tools, at least TortoiseSVN and Subclipse, the GUI does
not know what files will be committed at the time it would have to request
the message template. This isn't really a show stopper, but I think it
would give less than satisfactory results. Basically, if files were being
inserted into the template by the hook, the list might not be 100% accurate
as it would not include unversioned files that were going to be added
during the commit, and it would include files that the user might decide to
remove from the list. Obviously the user can manually fix the message
which is why it is not a show stopper.

2) TortoiseSVN lets the user start typing their commit message while the
code is crawling the WC looking for the changes. Since the filenames have
to be passed to the hook, they would have to drop this feature. I think
Stefan might consider this a show stopper and probably just wouldn't call
the hook. There are a lot of messages on the TSVN mailing list about this
feature in TSVN, so I would agree with him that a lot of his users want it.
FWIW, TSVN offers a similar feature by having a push button to paste
filenames into the message. This option does not appear until he is done
crawling the WC, and it takes into account the selections in the GUI.

In the case of GUI's, I think a property works better since it could be
retrieved from the WC up front, while still gathering the files. The GUI
could also perform its own substitution based on the selections in the UI.

I guess the other option is that the GUI's could call the hook up-front,
and not pass it any files. By convention, hook authors would have to be
aware of this and perhaps instructed to pass back a variable in the message
template where files are to be inserted?

Comments?

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 20 02:13:03 2005

This is an archived mail posted to the Subversion Dev mailing list.