Re: [PATCH] svnversion - current working directory

Christopher Ness <chris@nesser.org> writes:

> Index: main.c
> ===================================================================
> --- main.c (revision 14773)
> +++ main.c (working copy)
> @@ -131,7 +131,7 @@
> svn_error_clear
> (svn_cmdline_fprintf
> (stdout, pool,
> - _("usage: svnversion [OPTIONS] WC_PATH [TRAIL_URL]\n\n"
> + _("usage: svnversion [OPTIONS] [WC_PATH] [TRAIL_URL]\n\n"

I think this is too ambiguous, now. Does 'svnversion foo' now mean
WC_PATH == FOO, or TRAIL_URL == FOO?

You might have to either break it into two lines:

    usage: svnversion [OPTIONS]
           svnversion [OPTIONS] WC_PATH [TRAIL_URL]

Or teach the code to use the likes of svn_path_is_url() to determine,
in the 1-argument case, if that one argument was a working copy path
or a URL.

I wish I'd noticed the TRAIL_URL before ... the UI side-effects have
me less excited about this change.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 19 00:49:02 2005