[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] svnversion - current working directory

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-05-18 18:41:23 CEST

Christopher Ness <chris@nesser.org> writes:

> I got sick of typing svnversion without a path and getting the usage
> info.

Heh. I think I ran svnversion for one of the first times ever last
night, and had the same thought.

Your patch (thank you much), lacks a log message. Please see HACKING
for log message guidelines.

> Index: main.c
> ===================================================================
> --- main.c (revision 14773)
> +++ main.c (working copy)


> - SVN_INT_ERR (svn_utf_cstring_to_utf8 (&wc_path, os->argv[os->ind++], pool));
> + SVN_INT_ERR (svn_utf_cstring_to_utf8 (&wc_path,
> + (os->ind == argc) ? "." : os->argv[os->ind++],
> + pool));

I was about to fuss because "." is not canonical for Subversion
purposes, but then this section of code is dealing with user input,
not yet canonicalized anyway, so I'm pretty sure "." here is fine.

Why'd I bother calling that out? I dunno. It's Wednesday.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 18 18:42:44 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.