[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Log Message Templates vs Server->Client Configuration.

From: <kfogel_at_collab.net>
Date: 2005-05-17 06:21:05 CEST

Michael Sinz <michael.sinz@gmail.com> writes:
> 1) What happens with old clients and newer servers?
> (and the other way around)

Nothing special. The old clients never send that request, they just
commit as before. Of course, the pre-commit is still free to reject
improperly-formatted log messages, as it has always been.

This is why I think the log-template hook should not have the ability
to abort the commit; that should remain the province of the pre-commit
hook. After all, one might commit with -F or -m, and bypass any
possible template mechanism entirely. So pre-commit still handles
enforcement; log-template just helps the client comply.

(By the way, when a new client sends the request to an old server, it
just gets an error back and eats the error, pretending to the user
that nothing happened.)

> 2) If this requires only new clients and servers and the extra
> network turnaround is a problem, could this somehow be folded
> away in the case of no hook? (Again, assuming that is the
> best way to improve performance - I am not sure that this is
> the performance limit that we think it is)

I haven't been able to think of a way to avoid the extra request even
when there's no hook on the server side. On the other hand, we don't
know that it would actually cause responsiveness problems anyway.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 17 06:57:14 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.