[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14736 - in trunk/subversion: tests/clients/cmdline

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-05-16 18:46:57 CEST

kfogel@collab.net writes:

> philip@tigris.org writes:
> > --- trunk/subversion/libsvn_client/locking_commands.c (original)
> > +++ trunk/subversion/libsvn_client/locking_commands.c Sat May 14 15:26:16 2005
> > @@ -206,7 +206,7 @@
> > /* Open the common parent. */
> > SVN_ERR (svn_wc_adm_probe_open3 (parent_adm_access_p, NULL,
> > *common_parent,
> > - TRUE, 0, ctx->cancel_func,
> > + TRUE, -1, ctx->cancel_func,
> > ctx->cancel_baton, pool));
>
> No comments about the change itself, only:
>
> It might be good to have #define'd constants for depth arguments at
> this point. I just had to look up what -1 means, again :-).
>
> Any objections/thoughts before I do this?

IIRC, mod_dav supports (practically) arbitrary depths by simply
defining a DEPTH_INFINITY constant which == MAXINT. Depths are just
passed around as integers, which each recursive decrementing its copy
of the depth parameter until 0 is reached. There's no reason we
couldn't do the same, and arbitrary depth precision would allow GUI
clients to use this stuff for, say, arbitrary-depth caching of
information, or the likes.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 16 18:48:53 2005

This is an archived mail posted to the Subversion Dev mailing list.