[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14736 - in trunk/subversion: tests/clients/cmdline

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-14 23:02:32 CEST

On Sat, 14 May 2005 philip@tigris.org wrote:

> Author: philip
> Date: Sat May 14 15:26:16 2005
> New Revision: 14736
>
> Log:
> Open an access baton on the whole tree affected by the lock/unlock
> targets since gaps in the access baton tree are not supported.
>
> * subversion/libsvn_client/locking_commands.c
> (organize_lock_targets): Open/lock the whole tree.
>
> * subversion/tests/clients/cmdline/lock_tests.py
> (lock_several_files): New test.
> (test_list): Add lock_several_files.
>
>
> Modified: trunk/subversion/libsvn_client/locking_commands.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_client/locking_commands.c?rev=14736&p1=trunk/subversion/libsvn_client/locking_commands.c&p2=trunk/subversion/libsvn_client/locking_commands.c&r1=14735&r2=14736
> ==============================================================================
> --- trunk/subversion/libsvn_client/locking_commands.c (original)
> +++ trunk/subversion/libsvn_client/locking_commands.c Sat May 14 15:26:16 2005
> @@ -206,7 +206,7 @@
> /* Open the common parent. */
> SVN_ERR (svn_wc_adm_probe_open3 (parent_adm_access_p, NULL,
> *common_parent,
> - TRUE, 0, ctx->cancel_func,
> + TRUE, -1, ctx->cancel_func,
> ctx->cancel_baton, pool));
>
Seems a little heavy-weight to me. This means that if I lock a file in the
root of the repository, svn will lock the whole WC.

Wouldn't it be possible to, in the loop below, just svn_wc_adm_probe_try3
all the parents of each path from left to right?

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 14 22:54:18 2005

This is an archived mail posted to the Subversion Dev mailing list.