[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: assertion when locking files in different paths on RC4

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-05-14 22:18:07 CEST

On May 14, 2005, at 2:05 PM, Philip Martin wrote:
>
> Yes, svn_client_lock opens access batons in a way that is not
> guaranteed to work. The problem is that it opens a common parent with
> depth 0 and then each target with depth 0, which means there is the
> potential for intermediate directories without a lock, something the
> wc locking code has never supported.
>
> A simple fix would be to open the common parent with depth -1 and lock
> all sub-directories.
>

Nice analysis, Philip. Can you file this as a 1.2.1 bug, and assign
it to fitz? I think this was his code. :-)

This doesn't need to hold up svn 1.2.0; it's easily worked around via
multiple single-target calls to svn_client_lock(). (And the network
layers *still* do separate requests for each lock either way!)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 14 22:19:07 2005

This is an archived mail posted to the Subversion Dev mailing list.