[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: [PATCH] Issue #2188 - [API] svn_client_copy/move should error

From: Rowell, Geoff <growell_at_ENVOYWW.COM>
Date: 2005-05-14 14:59:06 CEST

S.Ramaswamy [mailto:ramaswamy@collab.net] wrote:
> As far as I could make out from the discussions on the lists and the
> tracker, the requirement is for the directory creation behavior of svn
> copy/move to be configurable, when the dst is an existing directory.
>
> Currently if the destination specified by the user is an existing
> directory, and the src is a directory as well, then
> a directory with name "dst + basename(src)" is created - this
surprises
> many users, who would much rather have an error thrown or make this
> behavior configurable. That's what this patch allows the non-cmdline
svn
> clients to do - calling svn_client_copy2() with dir_override=FALSE
will
> result in an error and dir_override=TRUE maintains the current
behaviour.
> I imagine that a GUI client like Tortoise will have a have a way of
> letting users configure this behaviour. If the src is a directory and
> dest_kind is svn_node_none, then the contents of the src dir are
copied
> into
> the new dst dir - no directory with name = "dst + basename(src)" is
> created
> in this case.

Y'know, an argument name of "dir_append" or "append_dir" would make
more sense than "dir_override". Plus, the sense is the same.

-Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 14 18:14:27 2005

This is an archived mail posted to the Subversion Dev mailing list.