Tim Wharton wrote:
>>Branko Čibej wrote:
>>
>>
>>
>>>I think your patch got mangled...can you resend and attach it? I'll
>>>test it and commit it if no one objects in a couple of days.
>>>
>>>
>>I don't object to the spirit of this patch. But at the very least it should follow our coding standards.
>>
>>
>
>I resent the mail as I accidently sent from an unsubscribed address and assume
>it had been refused by the list.
>The newer mail has the patch as an attachment with the same content/
>
>I'm happy to perform any modifications needed to bring the patch up to scratch.
>
>
Please read the HACKING file. It describes our coding style and patch
submission guidelines (you did get those right :). The first problem
with your patch is that the changes in the Python code exceed the
80-column line length limit (the .vcproj file doesn't have to conform to
those).
Two comments about your log message:
>* gen_win.py
> ( def write(self) ): Modified the calling of move_proj_file() for
> libaprutil.vcproj.ezt to pass an extra template parameter for the BDB
>path
> based on wether self.configure_apr_util is set or not.
>
>
The above simply isn't true. You modified gen_vcnet_vcproj.py, not
gen_win.py. The change location is (Generator.write), not (def
write(self)) -- that is, use the name of the method, not its declaration.
>* libaprutil.vcproj.ezt
> (VCCLCompilerTool.AdditionalIncludeDirectories Debug/Release):
> Added bdb include path if 'bdbpath' template variable is set.
> (VCCLCompilerTool.PreprocessorDefinitions Debug/Release):
> Define APU_USE_DB instead of APU_USE_SDBM if 'bdbpath' template
>variable is
> set.
> (VCCLCompilerTool.AdditionalDependencies Debug/Release):
> Added libdb42d.lib in debug or libdb42.lib in release build if
>'bdbpath'
> template variable is set.
>
You don't have to describe the exact location of the changes in the
.vcproj file; it's not as if those were functions, or anything.
Another, more general comment: I think it's a mistake to set the BDB
path in the .vcproj only if --enable-bdb-in-apr-util was specified. You
typically use that option only the first time you configure the apr-util
sources, but you can configure the working copy (that is, generate
.vcproj files) more than once. The second time around, unmodified
.vcproj files will overrwrite the modified ones. So I'd suggest to set
the BDB path in the .vcprojs unconditionally.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 14 17:17:11 2005