[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn-push crashes (under cygwin)

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-05-14 00:10:30 CEST

"Max Bowsher" <maxb@ukf.net> writes:

> Thanks for the report, I've discovered a bug in svn-push.c.
>
> Change the NULL parameter in the ra_src->do_diff() call to an empty
> string, i.e. "" .

If we assume that svn-push did, at one time, work then it appears that
NULL was once a valid argument to do_diff and that Subversion has
changed. At a guess I'd say that the reporter rewrite (r8840) which
happened just after 1.0, and just after svn-push was first committed,
is responsible. In earlier versions set_path used svn_path_join_many
and the NULL would not have been a problem.

The current documentation for svn_ra_do_diff it states that
diff_target is "optional", I'm not sure what this means but it looks
like further evidence that NULL used to be valid.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 14 00:11:47 2005

This is an archived mail posted to the Subversion Dev mailing list.