[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14098 - in trunk: . subversion/libsvn_client subversion/tests/clients/cmdline

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-05-13 15:36:06 CEST

John Szakmeister <john@szakmeister.net> writes:

> However, I didn't implement the input
> validation. I sat down to do it twice, and I kept stumbling on how to
> create an appropriate error for the user. I think it would be confusing
> to say something like "Must be one of revision BASE, COMMITTED, WORKING,
> or UNSPECIFIED" or that a revision is disallowed for any reason.

How else is the user going to know what to change?

> The user did nothing wrong,

Something is wrong since the revision cannot be used.

> and may have supplied a completely sound
> argument. So the attached patch has an assert() statement the for the
> moment. Do you have suggestions for what an appropriate error might look
> like?

How about SVN_ERR_UNSUPPORTED_FEATURE? I think any error is better
than an assert, for example you are forcing TSVN to implement the same
restriction to avoid the assert.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 13 16:22:11 2005

This is an archived mail posted to the Subversion Dev mailing list.